Skip to content

[LIVE-20052][APEX] Integrate Apex icon in onboarding #11320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 13, 2025
Merged

[LIVE-20052][APEX] Integrate Apex icon in onboarding #11320

merged 1 commit into from
Aug 13, 2025

Conversation

jiyuzhuang
Copy link
Contributor

@jiyuzhuang jiyuzhuang commented Aug 11, 2025 •
edited by atlassian bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

  • Add device icon for Apex (using the one for Flex) in sync onboarding.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jiyuzhuang jiyuzhuang self-assigned this Aug 11, 2025
@vercel Vercel
Copy link

vercel bot commented Aug 11, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2025 4:14pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2025 4:14pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2025 4:14pm
web-tools ⬜️ Ignored (Inspect) Visit Preview Aug 11, 2025 4:14pm

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Aug 11, 2025
@jiyuzhuang jiyuzhuang force-pushed the feat/live-20052 branch 2 times, most recently from 09b4a82 to f34dc0d Compare August 11, 2025 16:11
@jiyuzhuang jiyuzhuang marked this pull request as ready for review August 12, 2025 16:35
@jiyuzhuang jiyuzhuang requested a review from a team as a code owner August 12, 2025 16:35
@jiyuzhuang jiyuzhuang merged commit 74ae6a0 into develop Aug 13, 2025
64 checks passed
@jiyuzhuang jiyuzhuang deleted the feat/live-20052 branch August 13, 2025 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fAnselmi-Ledger fAnselmi-Ledger fAnselmi-Ledger approved these changes

Assignees

@jiyuzhuang jiyuzhuang

Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jiyuzhuang @fAnselmi-Ledger