Skip to content

Conversation

Moustafa-Koterba
Copy link
Contributor

@Moustafa-Koterba Moustafa-Koterba commented Aug 8, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • No impact

πŸ“ Description

Context

To be able to call the CAL dynamically, we need to inject the CryptoAssetsStore into concerned module. Implementation will be provided by LiveHub team. This ticket is for the Ethereum coin module.

What have changed

  • CryptoAssetsStore injected into coin-evm
  • A getter function is used instead of a variable for the CryptoAssetsStore, to be able to switch between legacy and new system with feature flag on runtime
  • Types are put into types-live package

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

Copy link

vercel bot commented Aug 8, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
web-tools Error Error Aug 22, 2025 8:05am
3 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Aug 22, 2025 8:05am
native-ui-storybook Ignored Ignored Preview Aug 22, 2025 8:05am
react-ui-storybook Ignored Ignored Preview Aug 22, 2025 8:05am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ledgerjs Has changes in the ledgerjs open source libs labels Aug 8, 2025
@ledger-wiz-cspm-secret-detection
Copy link

ledger-wiz-cspm-secret-detection bot commented Aug 8, 2025

Wiz Scan Summary

Scanner Findings
Data Finding Sensitive Data 1 Low
Secret Finding Secrets -
IaC Misconfiguration IaC Misconfigurations -
Total 1 Low

View scan details in Wiz

To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension.

@live-github-bot live-github-bot bot removed desktop Has changes in LLD mobile Has changes in LLM labels Aug 8, 2025
@live-github-bot live-github-bot bot removed the ledgerjs Has changes in the ledgerjs open source libs label Aug 11, 2025
@live-github-bot live-github-bot bot added the ledgerjs Has changes in the ledgerjs open source libs label Aug 11, 2025
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM cli labels Aug 11, 2025
@Moustafa-Koterba Moustafa-Koterba marked this pull request as ready for review August 11, 2025 15:22
@Moustafa-Koterba Moustafa-Koterba requested review from a team as code owners August 11, 2025 15:22
Copy link
Contributor

@sprohaszka-ledger sprohaszka-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Beware of all import path including lib part.
This should not be in the path when you import a file.

Comment on lines +742 to +743
findTokenByAddressInCurrency: (_address: string, _currencyId: string) => {
return _address === "0x000000000000000000000000000000000000dead"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Weird to prefix variables you actually use with _

Suggested change
findTokenByAddressInCurrency: (_address: string, _currencyId: string) => {
return _address === "0x000000000000000000000000000000000000dead"
findTokenByAddressInCurrency: (address: string, _currencyId: string) => {
return address === "0x000000000000000000000000000000000000dead"

@Moustafa-Koterba Moustafa-Koterba merged commit fd58c5f into develop Aug 22, 2025
137 of 143 checks passed
@Moustafa-Koterba Moustafa-Koterba deleted the feature/LIVE-19996 branch August 22, 2025 14:24
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required β‰₯ 80%)
2 New Code Smells (required ≀ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cli common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants