-
Notifications
You must be signed in to change notification settings - Fork 429
Feature/live 19996 #11313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/live 19996 #11313
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
3 Skipped Deployments
|
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
bf46c69
to
bacde96
Compare
bacde96
to
4265fa7
Compare
3d3d4fb
to
ad7d115
Compare
ad7d115
to
ca7e80e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Beware of all import path including lib
part.
This should not be in the path when you import
a file.
20c2c2d
to
072615b
Compare
cb8abfb
to
d6a6a94
Compare
findTokenByAddressInCurrency: (_address: string, _currencyId: string) => { | ||
return _address === "0x000000000000000000000000000000000000dead" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Weird to prefix variables you actually use with _
findTokenByAddressInCurrency: (_address: string, _currencyId: string) => { | |
return _address === "0x000000000000000000000000000000000000dead" | |
findTokenByAddressInCurrency: (address: string, _currencyId: string) => { | |
return address === "0x000000000000000000000000000000000000dead" |
|
β Checklist
npx changeset
was attached.π Description
Context
To be able to call the CAL dynamically, we need to inject the
CryptoAssetsStore
into concerned module. Implementation will be provided by LiveHub team. This ticket is for the Ethereum coin module.What have changed
CryptoAssetsStore
injected intocoin-evm
CryptoAssetsStore
, to be able to switch between legacy and new system with feature flag on runtimetypes-live
packageβ Context
π§ Checklist for the PR Reviewers