Skip to content

♻️ (llm) refactor useModularDrawerState #11310

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 19, 2025
Merged

♻️ (llm) refactor useModularDrawerState #11310

merged 1 commit into from
Aug 19, 2025

Conversation

LucasWerey
Copy link
Member

@LucasWerey LucasWerey commented Aug 8, 2025 •
edited by jira bot
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • MAD LLM

📝 Description

Refactor useModularDrawerState hook on LLM
Add tests
Add msw for suported currencies

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Aug 8, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for GitHub.

4 Skipped Deployments
Project Deployment Preview Comments Updated (UTC)
ledger-live-github-bot Ignored Ignored Preview Aug 19, 2025 9:41am
native-ui-storybook Ignored Ignored Preview Aug 19, 2025 9:41am
react-ui-storybook Ignored Ignored Preview Aug 19, 2025 9:41am
web-tools Ignored Ignored Preview Aug 19, 2025 9:41am

@live-github-bot live-github-bot bot added the mobile Has changes in LLM label Aug 8, 2025
@LucasWerey LucasWerey force-pushed the feat/LIVE-20619 branch 2 times, most recently from 6d1cc26 to 50e6314 Compare August 8, 2025 15:58
@LucasWerey LucasWerey marked this pull request as ready for review August 8, 2025 16:06
@LucasWerey LucasWerey requested a review from a team as a code owner August 8, 2025 16:06
mcayuelas-ledger
mcayuelas-ledger reviewed Aug 8, 2025
View reviewed changes
apps/ledger-live-mobile/src/newArch/features/ModularDrawer/hooks/useModularDrawerState.ts Outdated
availableNetworksCount: availableNetworks.length,
hasOneCurrency,
resetSelection: reset,
clearNetwork: () => setNetwork(undefined),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not a big fan of this, prefer func from other hook

Copy link
Member Author

@LucasWerey LucasWerey Aug 8, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdym? Wanna have a hook that will return reset, clearNetwork etc. ? Or just not an arrow func?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not have arrow function if possible? I think we already have this in a hook no?

@LucasWerey LucasWerey merged commit cf301f3 into develop Aug 19, 2025
54 of 55 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-20619 branch August 19, 2025 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@LucasWerey LucasWerey

Labels
mobile Has changes in LLM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasWerey @mcayuelas-ledger