Skip to content

feat(coin-monitoring): monitor tier two adresses #11183

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 5, 2025
Merged

feat(coin-monitoring): monitor tier two adresses #11183

merged 1 commit into from
Aug 5, 2025

Conversation

dilaouid
Copy link
Contributor

@dilaouid dilaouid commented Aug 1, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

Add datadog monitoring for tier two coins, exceptions are coins needing additionnal configurations to get the account shape (essentially cosmos)

⚠️ Mina is very slow

ℹ️ filecoin - hedera - tezos - near getAccountShape now returns a operationsCount property

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@dilaouid dilaouid self-assigned this Aug 1, 2025
@dilaouid dilaouid requested review from a team as code owners August 1, 2025 10:06
@vercel Vercel
Copy link

vercel bot commented Aug 1, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
web-tools ❌ Failed (Inspect) Aug 4, 2025 4:20pm
3 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Aug 4, 2025 4:20pm
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 4, 2025 4:20pm
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Aug 4, 2025 4:20pm

@live-github-bot live-github-bot bot added the coin-modules-api Has changes in the coin-framework/coin-modules APIs label Aug 1, 2025
@francois-guerin-ledger
Copy link
Contributor

I have 504 on https://xrp.coin.ledger.com

@dilaouid dilaouid requested review from a team as code owners August 4, 2025 16:08
@live-github-bot live-github-bot bot added mobile Has changes in LLM ledgerjs Has changes in the ledgerjs open source libs labels Aug 4, 2025
@live-github-bot live-github-bot bot removed mobile Has changes in LLM ledgerjs Has changes in the ledgerjs open source libs labels Aug 4, 2025
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Aug 4, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud

@dilaouid dilaouid merged commit 9dc5af1 into develop Aug 5, 2025
71 of 72 checks passed
@dilaouid dilaouid deleted the LIVE-20288 branch August 5, 2025 08:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francois-guerin-ledger francois-guerin-ledger francois-guerin-ledger approved these changes

Assignees

@dilaouid dilaouid

Labels
coin-modules-api Has changes in the coin-framework/coin-modules APIs
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dilaouid @francois-guerin-ledger