Skip to content

Conversation

LucasWerey
Copy link
Member

@LucasWerey LucasWerey commented Jul 1, 2025

βœ… Checklist

  • npx changeset was attached
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

πŸ“ Description

2 PRs changed the layout of various add account screens, resulting in disparities in margin. This PR fix the issues.
Also fix accountList item size so it looks better and there is no overlaps

Before After
image image
image image
image image

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner July 1, 2025 12:12
Copy link

vercel bot commented Jul 1, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

Name Status Preview Comments Updated (UTC)
react-ui-storybook βœ… Ready (Inspect) Visit Preview πŸ’¬ Add feedback Jul 1, 2025 0:41am
web-tools ❌ Failed (Inspect) Jul 1, 2025 0:41am
2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2025 0:41am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jul 1, 2025 0:41am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jul 1, 2025
@LucasWerey LucasWerey force-pushed the feat/margin_issue branch from 9e0b2a1 to 7c6a997 Compare July 1, 2025 12:15
@LucasWerey LucasWerey changed the title ✨ (LLD-AA) fix margin issue fund accounts ✨ (LLD-AA) fix spacing issues Jul 1, 2025
@LucasWerey LucasWerey force-pushed the feat/margin_issue branch from 7c6a997 to 32f5967 Compare July 1, 2025 12:35
@live-github-bot live-github-bot bot added the ui Has changes in the design system library label Jul 1, 2025
@LucasWerey LucasWerey merged commit 9d82ef4 into develop Jul 1, 2025
50 of 54 checks passed
@LucasWerey LucasWerey deleted the feat/margin_issue branch July 1, 2025 13:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD ui Has changes in the design system library
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants