Skip to content

Conversation

jiyuzhuang
Copy link
Contributor

@jiyuzhuang jiyuzhuang commented Jun 26, 2025

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:

📝 Description

  • Rework Recovery Key backup page for LLD and LLM;
  • Add animations;
  • Fix the bug in the link of the page.
  • This PR is also containing the work of LIVE-19504

❓ Context


🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@jiyuzhuang jiyuzhuang self-assigned this Jun 26, 2025
Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 26, 2025 3:20pm
native-ui-storybook ⬜️ Ignored (Inspect) Jun 26, 2025 3:20pm
react-ui-storybook ⬜️ Ignored (Inspect) Jun 26, 2025 3:20pm
web-tools ⬜️ Ignored (Inspect) Jun 26, 2025 3:20pm

@jiyuzhuang jiyuzhuang marked this pull request as ready for review June 26, 2025 15:20
@jiyuzhuang jiyuzhuang requested review from a team as code owners June 26, 2025 15:20
@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jun 26, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jun 26, 2025

Mobile Bundle Checks

Comparing 3de63c9 against 4e061f5.

⚠️ main.ios.jsbundle bundle size significantly increased: 65.7mb -> 66.1mb. Please check if this is expected.
⚠️ main.android.jsbundle bundle size significantly increased: 65.7mb -> 66.1mb. Please check if this is expected.

Desktop Bundle Checks

Comparing 3de63c9 against 7935e05.

@jiyuzhuang jiyuzhuang merged commit b18122c into develop Jun 27, 2025
68 of 70 checks passed
@jiyuzhuang jiyuzhuang deleted the feat/live-19493 branch June 27, 2025 15:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants