Skip to content

Conversation

LucasWerey
Copy link
Member

@LucasWerey LucasWerey commented Jun 26, 2025

βœ… Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • my ledger / i18next

πŸ“ Description

During add account rework, we changed all the _plural key to _other key as _plural isn't supported by i18next. We missed this one so this PR fixes the issue

image

image

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@LucasWerey LucasWerey requested a review from a team as a code owner June 26, 2025 10:29
Copy link

vercel bot commented Jun 26, 2025

The latest updates on your projects. Learn more about Vercel for Git β†—οΈŽ

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 26, 2025 10:29am
native-ui-storybook ⬜️ Ignored (Inspect) Jun 26, 2025 10:29am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 26, 2025 10:29am
web-tools ⬜️ Ignored (Inspect) Jun 26, 2025 10:29am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 26, 2025
@LucasWerey LucasWerey merged commit dcab567 into develop Jun 26, 2025
51 of 57 checks passed
@LucasWerey LucasWerey deleted the fix/LIVE-19917 branch June 26, 2025 12:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants