Skip to content

✨ (MAD) display testnet if dev mode is ON #10640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 23, 2025
Merged

✨ (MAD) display testnet if dev mode is ON #10640

merged 1 commit into from
Jun 23, 2025

Conversation

LucasWerey
Copy link
Member

@LucasWerey LucasWerey commented Jun 23, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • MAD assets list

📝 Description

Add test nets currency if dev mode is true.
There's not much perf consideration as we will display testNet only for dev so it's quite limited and I don't think there is a faster way to get testNets currencies

Screen.Recording.2025-06-23.at.11.28.38.AM.mov
Screen.Recording.2025-06-23.at.11.39.29.AM.mov

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@vercel Vercel
Copy link

vercel bot commented Jun 23, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 10:08am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 10:08am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 10:08am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 23, 2025 10:08am

@live-github-bot live-github-bot bot added the desktop Has changes in LLD label Jun 23, 2025
@LucasWerey LucasWerey marked this pull request as ready for review June 23, 2025 09:46
@LucasWerey LucasWerey requested review from a team as code owners June 23, 2025 09:46
@LucasWerey LucasWerey force-pushed the feat/LIVE-19778 branch 4 times, most recently from 57ffa71 to c336ede Compare June 23, 2025 09:58
@LucasWerey LucasWerey merged commit 5c8cf24 into develop Jun 23, 2025
49 of 50 checks passed
@LucasWerey LucasWerey deleted the feat/LIVE-19778 branch June 23, 2025 11:11
@woutershep woutershep mentioned this pull request Jul 9, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@LucasWerey LucasWerey

Labels
desktop Has changes in LLD
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@LucasWerey @mcayuelas-ledger