Skip to content

Conversation

philipptpunkt
Copy link
Contributor

fix wrong analytics data selector for swap webviews

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • ...

📝 Description

Replace this text by a clear and concise description of what this pull request is about and why it is needed. Be sure to explain the problem you're addressing and the solution you're proposing.
For libraries, you can add a code sample of how to use it.
For bug fixes, you can explain the previous behaviour and how it was fixed.
In case of visual features, please attach screenshots or video recordings to demonstrate the changes.

❓ Context

  • JIRA or GitHub link:

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

fix wrong analytics data selector for swap webviews
@philipptpunkt philipptpunkt requested a review from a team as a code owner June 19, 2025 11:35
Copy link

vercel bot commented Jun 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Jun 19, 2025 11:35am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2025 11:35am
react-ui-storybook ⬜️ Ignored (Inspect) Jun 19, 2025 11:35am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 19, 2025 11:35am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM labels Jun 19, 2025
@philipptpunkt philipptpunkt merged commit 01e275a into develop Jun 19, 2025
60 checks passed
@philipptpunkt philipptpunkt deleted the fix/LIVE-19694-analytics-opt-in-data-selector branch June 19, 2025 12:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
desktop Has changes in LLD mobile Has changes in LLM
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants