Skip to content

✨ (onboarding) [LIVE-18332]: Charon support #10591

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 16 commits into from
Jun 20, 2025
Merged

✨ (onboarding) [LIVE-18332]: Charon support #10591

merged 16 commits into from
Jun 20, 2025

Conversation

ofreyssinet-ledger
Copy link
Contributor

@ofreyssinet-ledger ofreyssinet-ledger commented Jun 18, 2025 •
edited
Loading

✅ Checklist

  • npx changeset was attached.
  • Covered by automatic tests.
  • Impact of the changes:
    • Stax & Flex onboarding.

📝 Description

See Jira ticket for more info.

❓ Context

🧐 Checklist for the PR Reviewers

  • The code aligns with the requirements described in the linked JIRA or GitHub issue.
  • The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
  • There are no undocumented trade-offs, technical debt, or maintainability issues.
  • The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
  • Any new dependencies have been justified and documented.
  • Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

@ofreyssinet-ledger ofreyssinet-ledger requested review from a team as code owners June 18, 2025 14:09
@vercel Vercel
Copy link

vercel bot commented Jun 18, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments
Name Status Preview Comments Updated (UTC)
ledger-live-github-bot ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 10:43am
native-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 10:43am
react-ui-storybook ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 10:43am
web-tools ⬜️ Ignored (Inspect) Visit Preview Jun 20, 2025 10:43am

@live-github-bot live-github-bot bot added desktop Has changes in LLD mobile Has changes in LLM common Has changes in live-common ui Has changes in the design system library ledgerjs Has changes in the ledgerjs open source libs translations Translation files have been touched labels Jun 18, 2025
@live-github-bot
Copy link
Contributor

live-github-bot bot commented Jun 18, 2025 •
edited
Loading

Desktop Bundle Checks

Comparing b9a1f03 against 8259a00.

⚠️ renderer bundle size significantly increased: 41.2mb -> 44.8mb. Please check if this is expected.

Mobile Bundle Checks

Comparing b9a1f03 against e977b11.

✅ Previous issues have all been fixed.

mcayuelas-ledger
mcayuelas-ledger previously approved these changes Jun 19, 2025
View reviewed changes
Copy link
Contributor

@mcayuelas-ledger mcayuelas-ledger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for Hub

jiyuzhuang
jiyuzhuang previously approved these changes Jun 20, 2025
View reviewed changes
aussedatlo and others added 10 commits June 20, 2025 11:14
@aussedatlo @ofreyssinet-ledger
✨(onboarding): Add Charon support
95bcad3
@ofreyssinet-ledger
🐛 (types): Fix types
f860bc6
@ofreyssinet-ledger
🐛 (onboarding): Disable "charon" restore choice when it's not supported
3ebc97f
@ofreyssinet-ledger
🐛 (lld): Typechecks
024b2e0
@ofreyssinet-ledger
🐛 (onboarding): Don't display Charon in first seed step if not supported
c406ec9
@ofreyssinet-ledger
🐛 (extractOnboardingState): WelcomeScreen1 shouldn't be overridden
6e83652
@ofreyssinet-ledger
🐛 (extractOnboardingState): Handle reboot when backup screens displayed
079e636
@ofreyssinet-ledger
💚 (connectManager): Remove unused imports
1dda7a8
@ofreyssinet-ledger
🧪 (extractOnboardingState): For Charon Backup, device is actually onb…
3f2f0f8 
…oarded

The wrong assumption was made in those tests. On the real OS, the isOnboarded flag will be true when the Charon Backup screens are shown, because the device is actually seeded at that point.
@ofreyssinet-ledger
🔇 (connectManager): Remove logs
812ffbc
@jiyuzhuang jiyuzhuang dismissed stale reviews from vcluzeau-ledger, mcayuelas-ledger, and themself via 1fc6f68 June 20, 2025 10:00
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
22 New Code Smells (required ≤ 1)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@ofreyssinet-ledger ofreyssinet-ledger merged commit f774592 into develop Jun 20, 2025
62 of 65 checks passed
@ofreyssinet-ledger ofreyssinet-ledger deleted the feat/charon-onboarding branch June 20, 2025 12:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jiyuzhuang jiyuzhuang jiyuzhuang approved these changes

@vcluzeau-ledger vcluzeau-ledger vcluzeau-ledger approved these changes

@mcayuelas-ledger mcayuelas-ledger mcayuelas-ledger approved these changes

Assignees

@ofreyssinet-ledger ofreyssinet-ledger

Labels
common Has changes in live-common desktop Has changes in LLD ledgerjs Has changes in the ledgerjs open source libs mobile Has changes in LLM translations Translation files have been touched ui Has changes in the design system library
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ofreyssinet-ledger @jiyuzhuang @vcluzeau-ledger @mcayuelas-ledger @aussedatlo