feat(lld, llm): target a custom reference of the CAL #10507
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
3 Skipped Deployments
|
live-github-bot
bot
added
desktop
francois-guerin-ledger
force-pushed
the
feat/LIVE-14974-cal-select-cal-branch
branch
from
859dce9 to
3a4eb17
Compare
francois-guerin-ledger
force-pushed
the
feat/LIVE-14974-cal-select-cal-branch
branch
from
3a4eb17 to
cd18afd
Compare
francois-guerin-ledger
dismissed stale reviews from mcayuelas-ledger and themooneer
via
5735489
francois-guerin-ledger
force-pushed
the
feat/LIVE-14974-cal-select-cal-branch
branch
from
cd18afd to
5735489
Compare
|
| signatureKind = "prod", | ||
| ref = getEnv("CAL_REF") || undefined, |
There was a problem hiding this comment.
Why don't we use the test signatureKind when not on the main branch ?
Because usually we won't have a prod signature if the branch is not main
There was a problem hiding this comment.
We don't use test because these signatures are not working at the moment, making this feature impossible to use...
A prod signature has been added on purpose here in order to make it work.
Maybe we can add a TODO explaining the situation ?
| const ref = useEnv("CAL_REF"); | ||
| const [inputValue, setInputValue] = useState(ref || "branch:next"); |
There was a problem hiding this comment.
maybe you could add a default value in env. file?
There was a problem hiding this comment.
Default is empty because in the nominal case, it must be empty as we want the CAL to select its own default (asserting LL always know the default is quite big).
I want this env filled only with an explicit action from the user.
| prepareCurrency: (currency: CryptoCurrency) => Promise<unknown | null | undefined>; | ||
| prepareCurrency: ( | ||
| currency: CryptoCurrency, | ||
| { forceUpdate }?: { forceUpdate: boolean }, |
There was a problem hiding this comment.
[ASK] why do you need an object?
There was a problem hiding this comment.
Because it is easier to understand what happens with prepareCurrency(coin, { forceUpdate: true }) as opposed to prepareCurrency(coin, true) that does not give much context.
✅ Checklist
npx changesetwas attached.📝 Description
Allow developers to target a specific version of the CAL for test purposes.
Expose
SPECULOS_API_PORTas global env, passing by.❓ Context
🧐 Checklist for the PR Reviewers