🐛 (cls): Remap device disconnected error

[jdabbech-ledger]

✅ Checklist

• npx changeset was attached.
• Covered by automatic tests.
• Impact of the changes:
  • ...

📝 Description

Map device disconnected from DMK during CLS update

use of withTransport instead of withDevice to fix retry after device session removed

❓ Context

• JIRA or GitHub link: LIVE-18720 LIVE-18926

---

🧐 Checklist for the PR Reviewers

• The code aligns with the requirements described in the linked JIRA or GitHub issue.
• The PR description clearly documents the changes made and explains any technical trade-offs or design decisions.
• There are no undocumented trade-offs, technical debt, or maintainability issues.
• The PR has been tested thoroughly, and any potential edge cases have been considered and handled.
• Any new dependencies have been justified and documented.
• Performance considerations have been taken into account. (changes have been profiled or benchmarked if necessary)

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

4 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
ledger-live-github-bot	⬜️ Ignored (Inspect)	Visit Preview		Jun 19, 2025 0:44am
native-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Jun 19, 2025 0:44am
react-ui-storybook	⬜️ Ignored (Inspect)	Visit Preview		Jun 19, 2025 0:44am
web-tools	⬜️ Ignored (Inspect)	Visit Preview		Jun 19, 2025 0:44am

[mcayuelas-ledger]

Suggested change

	const translatedErrorStringId = `errors.${error._tag}.${field}`;
	if (t(translatedErrorStringId) !== translatedErrorStringId) {
	return <Text>{t(translatedErrorStringId)}</Text>;
	} else {
	const message =
	field === "title"
	? error._tag
	: (error?.originalError as Error)?.message ?? error.message ?? error._tag;
	const translatedKey = `errors.${error._tag}.${field}`;
	const translated = t(translatedKey);
	if (translated !== translatedKey) {
	return <Text>{translated}</Text>;
	}
	const fallbackMessage =
	field === "title"
	? error._tag
	: (error?.originalError as Error)?.message ?? error.message ?? error._tag;
	return <Text>{t(`errors.generic.${field}`, { message: fallbackMessage })}</Text>;

I think it has better readability and avoid repeated translation calls.

• translatedKey and translated make the intent clearer.
• We evaluate t(translatedKey) only once to avoid unnecessary function calls.

[Copilot]

Pull Request Overview

This PR remaps the device disconnected error from DMK during a custom lock screen update and updates the associated error handling and device selection workflows. Key changes include:

• Replacing withDevice with withTransport in customLockScreenLoad to address device session removal and updating error handling for DMK disconnect cases.
• Updating tests in customLockScreenLoad.test to align with the new transport API.
• Enhancing the device selection hook and UI in the mobile app by introducing selectDevice and registerDeviceSelection functions, along with updating related components and localization.

Reviewed Changes

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file

File	Description
libs/ledger-live-common/src/hw/customLockScreenLoad.ts	Refactors device API usage by replacing withDevice with withTransport and adds DMK error type checking
libs/ledger-live-common/src/hw/customLockScreenLoad.test.ts	Updates tests to support transportRef and DMK error scenarios
apps/ledger-live-mobile/src/newArch/features/DeviceSelection/screens/SelectDevice/useSelectDeviceViewModel.ts	Adds a callback registration and updates device selection handling
apps/ledger-live-mobile/src/newArch/features/DeviceSelection/screens/SelectDevice/index.tsx	Updates component props to use the new device selection API
apps/ledger-live-mobile/src/locales/en/common.json	Extends localization for DMK errors
apps/ledger-live-mobile/src/components/TranslatedError/TranslatedError.tsx	Adjusts error translation for DMK errors using new keys
.changeset/*.md	Documents the changes with appropriate release notes

Comments suppressed due to low confidence (1)

apps/ledger-live-mobile/src/components/TranslatedError/TranslatedError.tsx:31

• [nitpick] Consider adding a comment to explain the fallback behavior in error translation when a specific DMK error translation key is missing, so future developers understand the rationale behind calling the generic translation.

    const translatedKey = `errors.${error._tag}.${field}`;

[Copilot]

The type guard for DMK device disconnection error works as expected; consider ensuring that checking for 'err !== null' and property '_tag' is sufficient for all cases you expect, and document its intent for future maintainers.

Suggested change

	const isDmkDeviceDisconnectedError = (err: unknown): err is DeviceDisconnectedWhileSendingError =>
	err !== null &&
	(err instanceof DeviceDisconnectedWhileSendingError ||
	(typeof err === "object" &&
	"_tag" in err &&
	err._tag === "DeviceDisconnectedWhileSendingError"));
	/**
	* Type guard to check if the given error is a DeviceDisconnectedWhileSendingError.
	* Ensures that the error is an object, is not null, and matches the expected structure.
	* This is used to identify specific disconnection errors from the DMK device.
	*/
	const isDmkDeviceDisconnectedError = (err: unknown): err is DeviceDisconnectedWhileSendingError =>
	typeof err === "object" &&
	err !== null &&
	(err instanceof DeviceDisconnectedWhileSendingError ||
	("_tag" in err && err._tag === "DeviceDisconnectedWhileSendingError"));

[sonarqubecloud]

Quality Gate failed

Failed conditions
15.6% Coverage on New Code (required ≥ 80%)

See analysis details on SonarQube Cloud