Use big-endian for long APDUs data length in header #283
+1
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yogh333
reviewed
Aug 25, 2025
We can batch it with the changes in the next release, not urgent! |
bigspider
force-pushed
the
long-apdu-encoding
branch
from
fe98666 to
0101cd9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The standard expects a 7-bytes header with the length expressed as a 0 followed by a 2-byte length in big-endian. The Rust SDK is incorrectly using little-endian.
This is technically a breaking change - but no Rust app currently uses long APDUs.
One example of an app in C using long APDUs (with the correct big-endian length encoding) is
app-security-key, which decodes the APDU here.