Weak syscalls fix #282
Open
Weak syscalls fix #282
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes sure that the symbols with __attribute((weak)) defined in syscalls.c don't override the strong definitions elsewhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many syscalls are defined in
syscalls.cas weak, because a second implementation in the SDK can replace them. This is needed for many features, as the code compiled by the feature provides a different implementation under the control of the app.This PR separates the compilation of
syscalls.cin a separate object file that is compiled last, which allows the linker to choose the strong definition if it exists. Some refactoring was needed because includes need to be present in both cases, unlike C files that must not be duplicated.After doing so, I was having linker errors related to the functions in
u2f_transport.c, which indeed was not compiled. So I added the configuration for that in the second commit.