Wip #314
Draft
Wip #314
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #314 +/- ##
========================================
Coverage 84.70% 84.70%
========================================
Files 17 17
Lines 2230 2230
========================================
Hits 1889 1889
Misses 341 341
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Merged
bigspider
force-pushed
the
baseapp
branch
2 times, most recently
from
4f58200 to
b3bdffb
Compare
bigspider
force-pushed
the
baseapp
branch
3 times, most recently
from
961dc9d to
d6c74fb
Compare
bigspider
force-pushed
the
baseapp
branch
4 times, most recently
from
c8ba6c0 to
2d11cf2
Compare
iartemov-ledger
force-pushed
the
baseapp
branch
2 times, most recently
from
e9d64a9 to
401e5d9
Compare
- Compute internal_inputs_total_amount - Allow sign_psbt to continue even if no wallet_policy is specified - Disable checks that do not make sense if no wallet policy is present - Fail if sighash is not ALL/DEFAULT - Don't fail if no input is internal to the wallet policy (needed when the derived app is signing a transaction with custom inputs only) - Delete swap-related checks - Delete display_transaction and related functions - Add weak functions validate_and_display_transaction and sign_custom_inputs to allow derived apps to hook into the signing flow
) only custom inputs. The way the code was written, the signing flow would be skipped if there is no internal inputs that can be signed with the wallet policy. This is incorrect, as some apps might need to sign such transactions. This also removes the logic related to MuSig2, which is anyway disabled and therefore redundant.
iartemov-ledger
force-pushed
the
baseapp
branch
from
143d64b to
d4b1eb9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.