fix: storage layout regression #446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compared storage inspects between
|
|
But now the RegistryCoordinator storage layout is now appended at the end and is different from the previous |
I don't know of anyone who upgraded on testnet, but we would need to create essentially a SlashingRegistryCoordinatorBase without EIP712 to resolve this, and then have RegistryCoordinator and SlashingRegistry coordinators inherit that separately to fully resolve this |
8sunyuan
approved these changes
Apr 1, 2025
This was referenced Apr 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
regression in the src / rc storage layouts
Modifications:
Re-order the inheritance to preserve the storage layout from the v0.5.4 rewards release
Result:
Consistent storage layout between releases