feat: paymentInitiator role in ServiceManagerBase
#260
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- creating ServiceManagerBaseStorage - adding paymentInitiator storage var to ServiceManagerBase - adding ability for owner to change paymentInitiator - formatting based on forge fmt for contracts modified
diyahir
changed the title
paymentInitiator role in ServiceManagerBasepaymentInitiator role in ServiceManagerBase
8sunyuan
reviewed
May 22, 2024
8sunyuan
reviewed
May 22, 2024
8sunyuan
reviewed
May 22, 2024
- removing erroneous gap from `ServiceManagerBase` - typo 50 to 49 - making inheritance backward compatible
8sunyuan
approved these changes
May 28, 2024
There was a problem hiding this comment.
LGTM appreciate the idea and implementation on this. Going to ping for another approval on this before merging.
Also want to flag that there will be another follow-up PR to this based on the PaymentCoordinator being renamed to RewardsCoordinator. WIP PR can be found here
Layr-Labs/eigenlayer-contracts#565
wadealexc
approved these changes
May 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, the entity responsible for posting the range payments is the
ServiceManagerOwner, but for practical purposes this responsibility will likely be delegated to a separate entity or smart contract.High level changes:
ServiceManagerBaseStorage.solpaymentInitiatorstorage var toServiceManagerBaseStoragepaymentInitiatorpaymentInitiatorrole