perf: add cache for forge build #1125
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bowenli86
force-pushed
the
perf/cache
branch
from
b5bc8d7 to
d35f0ea
Compare
bowenli86
force-pushed
the
perf/cache
branch
from
d35f0ea to
6bf4b95
Compare
bowenli86
changed the title
0xClandestine
previously approved these changes
Feb 18, 2025
| path: | | ||
| cache/ | ||
| out/ | ||
| key: ${{ runner.os }}-forge-${{ hashFiles('**/foundry.toml', '**/remappings.txt', 'src/**/*.sol', 'lib/**/*.sol') }} |
There was a problem hiding this comment.
Is it possible to use the commit hash as the key? Since the above defined files may not necessarily change.
There was a problem hiding this comment.
don't hv strong opinion, any special benefits of using commit hash?
benefits of current way it's more cohesive within iterations of a given PR, which may hv multiple rounds of CI and build can be totally skipped
.github/workflows/foundry.yml
Outdated
| # Cache Foundry dependencies | ||
|
|
||
| # Restore Foundry and Forge cache | ||
| - name: Cache Foundry dependencies |
There was a problem hiding this comment.
Capitalize first letters
Suggested change
| - name: Cache Foundry dependencies | |
| - name: Cache Foundry Dependencies |
0xClandestine
changed the title
|
looks like the approval is gone after i fixed typo, @0xClandestine needs another approval pls |
0xClandestine
approved these changes
Feb 18, 2025
ypatil12
pushed a commit
that referenced
this pull request
Feb 22, 2025
**Motivation:** after multiple round of optimization, the bottleneck in CI is forge build now, which takes 1.2-1.5min this PR added caching for forge build, so that every CI run can restore latest cache, and only compile solidity files that hv been changed, which significantly lowers compile time from 1.2-1.5min t0 <1s **Modifications:** this PR added caching for forge build, so that every CI run can restore latest cache, and only compile solidity files that hv been changed **Result:** significantly lowers compile time from 1.2-1.5min to <1s before adding cache:  after adding cache: 
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
after multiple round of optimization, the bottleneck in CI is forge build now, which takes 1.2-1.5min
this PR added caching for forge build, so that every CI run can restore latest cache, and only compile solidity files that hv been changed, which significantly lowers compile time from 1.2-1.5min t0 <1s
Modifications:
this PR added caching for forge build, so that every CI run can restore latest cache, and only compile solidity files that hv been changed
Result:
significantly lowers compile time from 1.2-1.5min to <1s
before adding cache:
after adding cache:
