perf: speed up test coverage job in CI #1115
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
bowenli86
changed the title
|
Surprised this worked, pre parallelism caching led to longer ci times. |
0xClandestine
requested changes
Feb 16, 2025
bowenli86
force-pushed
the
feat/coverage
branch
from
721b620 to
10d805b
Compare
|
the most expensive part now of coverage is now installing loc |
0xClandestine
requested changes
Feb 17, 2025
0xClandestine
force-pushed
the
feat/coverage
branch
from
0eaccd4 to
e0ec05c
Compare
0xClandestine
requested changes
Feb 17, 2025
0xClandestine
force-pushed
the
feat/coverage
branch
from
8d6c3d5 to
e0ec05c
Compare
0xClandestine
approved these changes
Feb 17, 2025
ypatil12
approved these changes
Feb 17, 2025
|
🔥🔥🔥 |
ypatil12
pushed a commit
that referenced
this pull request
Feb 22, 2025
**Motivation:** After multiple improvements to other parts of our CI, the coverage job has become the longest-running task, limiting the total CI runtime. This PR significantly reduces the coverage runtime from **16-18 minutes** (already down from **26 minutes** thanks to a previous improvement using an x64 16-core runner) to just **2 minutes**—an **8-9x speedup**. **Modifications:** - Parallelized coverage report generation. - Cached Foundry and Cargo artifacts. - Optimized Forge arguments. **Result:** The coverage runtime is reduced from **16-18 minutes** (previously **26 minutes**) to **2 minutes**, achieving an **8-9x improvement**. --------- Co-authored-by: clandestine.eth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
After multiple improvements to other parts of our CI, the coverage job has become the longest-running task, limiting the total CI runtime.
This PR significantly reduces the coverage runtime from 16-18 minutes (already down from 26 minutes thanks to a previous improvement using an x64 16-core runner) to just 2 minutes—an 8-9x speedup.
Modifications:
Result:
The coverage runtime is reduced from 16-18 minutes (previously 26 minutes) to 2 minutes, achieving an 8-9x improvement.