perf: run Foundry CI tests only for relevant code changes #1112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xClandestine
requested changes
Feb 16, 2025
0xClandestine
force-pushed
the
perf/path
branch
from
33917d0 to
1693d4a
Compare
|
Why aren't the foundry tests being skipped? |
Oh because .github/ is in path |
0xClandestine
changed the title
0xClandestine
approved these changes
Feb 17, 2025
ypatil12
approved these changes
Feb 17, 2025
ypatil12
pushed a commit
that referenced
this pull request
Feb 22, 2025
**Motivation:** Foundry tests only need to run when specific codebase paths are modified, rather than for all changes. For example, tests are not required when only documentation or deployment scripts are updated. **Modifications:** - Added a list of code paths that trigger Foundry tests when modified. **Result:** - Speeds up CI for non-core contract changes. - Reduces CI costs. --------- Co-authored-by: clandestine.eth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation:
Foundry tests only need to run when specific codebase paths are modified, rather than for all changes.
For example, tests are not required when only documentation or deployment scripts are updated.
Modifications:
Result: