Skip to content

fix: no local flags for skipping socket registry, only warn #964

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 5, 2024
Merged

fix: no local flags for skipping socket registry, only warn #964

merged 1 commit into from
Dec 5, 2024

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Dec 5, 2024

Why are these changes needed?

Always try to bind with socket registry, don't panic if not

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen requested a review from pschork December 5, 2024 18:18
@hopeyen hopeyen merged commit 626d97b into master Dec 5, 2024
10 checks passed
@hopeyen hopeyen deleted the hope/no-flag-socket-registry branch December 5, 2024 18:32
pschork pushed a commit that referenced this pull request Dec 5, 2024
@hopeyen @pschork
fix: no local flags for skipping socket registry, only warn (#964)
6f5dd0b
pschork pushed a commit that referenced this pull request Dec 5, 2024
@hopeyen @pschork
fix: no local flags for skipping socket registry, only warn (#964)
82af794
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pschork pschork pschork approved these changes

+1 more reviewer

@jianoaix jianoaix jianoaix approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hopeyen @pschork @jianoaix