docs(integration): update spec for encoded payload definition and update blob decoding #1891
Conversation
…ob decoding section
|
The latest Buf updates on your PR. Results from workflow Buf Proto / buf (pull_request).
|
bxue-l2
changed the title
| @@ -25,7 +25,8 @@ The golang payload clients provided in the eigenda repo currently only support [ | |||
| 0x00, payload[n:len(payload)], 0x00, ..., 0x00] | |||
| ``` | |||
|
|
|||
| where the last chunk is padded with 0s such that the total length is a multiple of 32 bytes. | |||
| - The final part of the payload is zero-padded so total length is a multiple of 32 bytes. | |||
There was a problem hiding this comment.
multiple of 32 bytes - or multiple of 32 bytes AND power of 2?
There was a problem hiding this comment.
+1. It's written as a separate bullet point but I feel like they should be combined since its all about padding. And actually this one bullet point is a subset of the other one, so can be removed.
There was a problem hiding this comment.
now a single bulletin 8f7252f#diff-7f28558dceb46b7608962e235cca775bfe85bd751dbc529a6e8b15a3d98fec36R27
| The preimage oracle served encoded payload. When the EigenDA blob derivation queries the preimage oracle for the encoded payload corresponding to a DA cert, the preimage oracle (i.e. the preimage request module of the EigenDA proxy) downloads the EigenDA blob from relay or directly from EigenDA operators. | ||
| If verification fails, it discards the blob and retries with other sources until a valid one is found. Once verified, it returns the encoded payload to the derivation step. | ||
| The preimage oracle performs checks on the blob against the KZG commitment from the DA cert. | ||
| If verification fails, it discards the blob and retries with other sources until a valid one is found. Once verified, it returns the encoded payload to the derivation step. |
There was a problem hiding this comment.
looks like this is duplicated with line 166
| @@ -25,7 +25,8 @@ The golang payload clients provided in the eigenda repo currently only support [ | |||
| 0x00, payload[n:len(payload)], 0x00, ..., 0x00] | |||
| ``` | |||
|
|
|||
| where the last chunk is padded with 0s such that the total length is a multiple of 32 bytes. | |||
| - The final part of the payload is zero-padded so total length is a multiple of 32 bytes. | |||
There was a problem hiding this comment.
+1. It's written as a separate bullet point but I feel like they should be combined since its all about padding. And actually this one bullet point is a subset of the other one, so can be removed.
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
bxue-l2
deleted the
docs--update-spec-to-encoded-payload-and-clarify-derivation-procedures
branch
Why are these changes needed?
Summary
Updates EigenDA specification documentation to clarify encoded payload definitions and blob derivation procedures:
Checks