Skip to content

fix: downgrade logging if attestation does not exist yet #1847

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Aug 7, 2025
Merged

fix: downgrade logging if attestation does not exist yet #1847

merged 1 commit into from
Aug 7, 2025

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Aug 7, 2025

Why are these changes needed?

when a blob has just been dispersed and has not been processed by the dispatcher, no attestations are expected and it should not emit any error logs.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim marked this pull request as ready for review August 7, 2025 15:57
@ian-shim ian-shim added this pull request to the merge queue Aug 7, 2025
Merged via the queue into Layr-Labs:master with commit 8813a97 Aug 7, 2025
23 of 25 checks passed
@ian-shim ian-shim deleted the downgrade-log-attestation-not-found branch August 7, 2025 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@litt3 litt3 litt3 approved these changes

@cody-littley cody-littley Awaiting requested review from cody-littley

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @dmanc @litt3