fix: remove blacklist wiring from nodes #1788
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest Buf updates on your PR. Results from workflow Buf Proto / buf (pull_request).
|
litt3
reviewed
Jul 22, 2025
| @@ -134,13 +134,6 @@ func (s *ServerV2) StoreChunks(ctx context.Context, in *pb.StoreChunksRequest) ( | |||
| return nil, api.NewErrorInvalidArg(fmt.Sprintf("failed to serialize batch header hash: %v", err)) | |||
| } | |||
|
|
|||
| // If the disperser is blacklisted and the blob authenticator is not nil, return an error | |||
| // we don't want to blacklist the disperser if the blob authenticator is nil since that indicated v1 | |||
| if s.node.BlacklistStore.IsBlacklisted(ctx, in.GetDisperserID()) && s.config.EnableV2 { | |||
There was a problem hiding this comment.
Given it's not longer used, consider also deleting the instantiation of the BlacklistStore inside node.go
There was a problem hiding this comment.
Will make the PR bigger, but sure.
dmanc
approved these changes
Jul 22, 2025
dmanc
pushed a commit
that referenced
this pull request
Jul 22, 2025
* removing blacklist wiring and check * removing blacklist test * fixing unit tests * removing node initialization --------- Co-authored-by: anupsv <[email protected]>
dmanc
added a commit
that referenced
this pull request
Jul 22, 2025
fix: remove blacklist wiring from nodes (#1788) * removing blacklist wiring and check * removing blacklist test * fixing unit tests * removing node initialization --------- Co-authored-by: anupsv <[email protected]> Co-authored-by: anupsv <[email protected]>
pakim249CAL
pushed a commit
that referenced
this pull request
Jul 22, 2025
* removing blacklist wiring and check * removing blacklist test * fixing unit tests * removing node initialization --------- Co-authored-by: anupsv <[email protected]>
pakim249CAL
pushed a commit
that referenced
this pull request
Jul 23, 2025
* removing blacklist wiring and check * removing blacklist test * fixing unit tests * removing node initialization --------- Co-authored-by: anupsv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
We are removing the wiring of the blacklist feature. I.E we are removing the place where it is added to the list and the place where it was being checked. We are also removing the integration test which was testing these features.
Checks