chore: cherry-pick celo's PR from proxy repo #1776
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Write on cache miss flag * Fix category * Update help * Update docs/help_out.txt Co-authored-by: Samuel Laferriere <[email protected]> * Update flag doc * Add e2e test for WriteOnCacheMiss flag * Fix lint --------- Co-authored-by: Samuel Laferriere <[email protected]>
litt3
previously approved these changes
Jul 17, 2025
api/proxy/.golangci.yml
Outdated
| @@ -17,7 +17,7 @@ linters: | |||
| - unused # checks for unused constants, variables, functions and types | |||
| ## disabled by default | |||
| - asasalint # checks for pass []any as any in variadic func(...any) | |||
| - asciicheck # checks that your code does not contain non-ASCII identifiers | |||
| - asciicheck # checks that your code does not contain non-ASCII identifiers1 | |||
api/proxy/.golangci.yml
Outdated
| @@ -195,7 +195,7 @@ linters: | |||
| - unparam | |||
|
|
|||
| # Allow certain patterns to be ignored by lll (long lines) | |||
| - source: '".{120,}"' # Ignores double-quoted strings longer than 120 chars | |||
| - source: '".{100,}"' # Ignores double-quoted strings longer than 120 chars | |||
There was a problem hiding this comment.
I know... but otherwise there was a bug which the celo engineer was running into and he didn't find another way to solve it. See https://eigenlabs.slack.com/archives/C07614NNXDH/p1751913947976629?thread_ts=1750965737.272329&cid=C07614NNXDH
There was a problem hiding this comment.
Fixed comment and added some "explanation" in 2c50038
Tbf I don't understand the bug so not super sure... but its not super important to me we can keep tweaking this in another PR I think, given that this blocks the 2.1 release we're trying to achieve and I want this to be included.
litt3
approved these changes
Jul 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls in latest PR on proxy repo: Layr-Labs/eigenda-proxy#422
I think I made a mistake and squash merged #1611, because subtree pull was giving me this error (same when trying with --squash):
But TIL that git is smart when cherry-picking and has a directory-rename feature, so the changes were automatically applied to the files under api/proxy, except for 2 small weirdness: