fix: Initialize connection with validator in background goroutine #1769
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
litt3
previously approved these changes
Jul 16, 2025
disperser/controller/dispatcher.go
Outdated
|
|
||
| d.pool.Submit(func() { | ||
| defer validatorProbe.End() |
There was a problem hiding this comment.
this defer should be moved to the top of the func
There was a problem hiding this comment.
Good catch, done
litt3
approved these changes
Jul 16, 2025
ian-shim
approved these changes
Jul 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Do not initialize grpc connections on the main batch creation goroutine. In extreme cases, grpc connections can take several seconds to set up.