Skip to content

fix: disperser_client v2 nil ptr bug #1710

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 2, 2025
Merged

fix: disperser_client v2 nil ptr bug #1710

Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d804acb
fix: disperser_client v2 nil ptr bug
samlaf Jul 2, 2025
d6a9d73
fix: another nil pointer
samlaf Jul 2, 2025
32309fe
fix: another nil ptr
samlaf Jul 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions api/clients/v2/disperser_client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,14 +452,14 @@ func convertLegacyPaymentStateToNew(legacyReply *disperser_rpc.GetPaymentStateRe
}

// Apply the global params to all quorums, both on-demand and reservation.
onDemandQuorums := legacyReply.PaymentGlobalParams.OnDemandQuorumNumbers
onDemandQuorums := legacyReply.GetPaymentGlobalParams().OnDemandQuorumNumbers
if len(onDemandQuorums) == 0 {
// Disperser v0.9.0 has a bug where it does not return on-demand quorums: https://github.com/Layr-Labs/eigenda/pull/1699
// Until we upgrade all dispersers, we will assume that on-demand quorums are 0 and 1.
// TODO: this should instead return an error once we have upgraded all dispersers.
onDemandQuorums = []uint32{0, 1}
}
reservationQuorums := legacyReply.Reservation.QuorumNumbers
reservationQuorums := legacyReply.GetReservation().QuorumNumbers
// There may be overlapping quorums but it doesn't matter since we will apply the same global params to all of them.
allQuorums := append(reservationQuorums, onDemandQuorums...)

Expand Down
Loading