-
Notifications
You must be signed in to change notification settings - Fork 237
feat: Implement claude log preprocessing command #1692
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: litt3 <[email protected]>
.claude/commands/PreprocessLogs.md
Outdated
@@ -0,0 +1,215 @@ | |||
# Preprocess Logs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we follow the snake-case style of other commands?
Which commands are snake case?
I did /preprocess-logs
, and the other multi-word commands follow the same -
formatting, e.g /add-dir
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also should we prefix with eigenda so we know it comes from this repo?
Hmm, good question. The description of the command is suffixed with (project)
, which lets us know it isn't a default command. Are you suggesting that we change the actual text of the slash command, or just the title of the command definition?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Which commands are snake case?
Sorry meant separating using hyphens casing. The picture I showed above is misleading, it's the behavior if we change the filename to preprocess-logs.md
. This is the current behavior:
Hmm, good question. The description of the command is suffixed with (project), which lets us know it isn't a default command. Are you suggesting that we change the actual text of the slash command, or just the title of the command definition?
Yeah was suggesting changing the title but didn't realize it already appends (project) to the description. Seems we can also utilize namespaces once we get more of these scripts. https://docs.anthropic.com/en/docs/claude-code/slash-commands#namespacing.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Gotcha! Yes I agree, we need to follow the hyphen
style. I'll make the change 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -17,7 +17,6 @@ lightnode/docker/args.sh | |||
.idea | |||
.env | |||
.vscode | |||
.claude |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a CLAUDE.md at some point?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Where is the proper place to put claude configuration that I don't want to commit?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we add a CLAUDE.md at some point?
Yes, I think we definitely should. I've been working on a draft, I hope to put up an initial proposal today!
Where is the proper place to put claude configuration that I don't want to commit?
~/.claude/CLAUDE.md
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here is the CLAUDE.md
proposal I referenced
Signed-off-by: litt3 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, although I haven't tested it myself yet.
* Implement claude log preprocessing command Signed-off-by: litt3 <[email protected]> * Add ripgrep to mise.toml Signed-off-by: litt3 <[email protected]> * Rename file to follow proper command format Signed-off-by: litt3 <[email protected]> --------- Signed-off-by: litt3 <[email protected]>
* Implement claude log preprocessing command Signed-off-by: litt3 <[email protected]> * Add ripgrep to mise.toml Signed-off-by: litt3 <[email protected]> * Rename file to follow proper command format Signed-off-by: litt3 <[email protected]> --------- Signed-off-by: litt3 <[email protected]>
/preprocess-logs