-
Notifications
You must be signed in to change notification settings - Fork 237
feat: eth client address directory #1691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
cf716c1
feat: integrate address directory to eth reader
hopeyen 2a9ba2d
feat: fix BLS_OPERATOR_STATE_RETRIEVER typo
hopeyen 23bbb80
refactor: config valid check, interface binding, getAddress0
hopeyen abca944
fix: check zero addr, rm unused binding, err msg
hopeyen 6cc92c7
feat: address directory reader
hopeyen 47420e9
refactor: abstract the getter
hopeyen ef7fdf5
rebase: master; add check of contract names
hopeyen 4979872
refactor: remove old new eth reader/writer method
hopeyen 7bdc315
refactor: update flags and configs for address dir
hopeyen 783556e
fix: chuner config lint
hopeyen 9b8c410
fix: more lints
hopeyen 373a59a
fix: more lints
hopeyen 8d7091c
fix: inabox config
hopeyen d54cc18
refactor(ethClient): comment cleanup
hopeyen 68389e8
Merge branch 'master' into hope/integrate-address-directory
hopeyen 7a9aee4
refactor(EigenDADirectory): update names and validation
hopeyen a01d3cf
refactor(EigenDADirectory): always get latest list of contract names
hopeyen f3f3f7a
Merge branch 'master' into hope/integrate-address-directory
hopeyen be3da55
fix(EigenDADirectory): add service manager flag back to retreiver
hopeyen d037753
refactor(proxy): add address directory config
hopeyen 0018c86
refactor(proxy): add address directory config in test setup
hopeyen 4b8e39f
refactor(EigenDADirectory): rename more address directory to eigenda …
hopeyen 1ea1ff4
refactor(EigenDADirectory): more renaming
hopeyen 569ba0e
fix(EigenDADirectory): relay inabox config
hopeyen ad4775d
fix(EigenDADirectory): add back flags and configs
hopeyen e24d27a
Merge branch 'master' into hope/integrate-address-directory
hopeyen 29e64a1
fix(EigenDADirectory): add back flags and configs
hopeyen 7651b9b
fix(EigenDADirectory): inabox config
hopeyen 5dc336e
fix(EigenDADirectory): make all three flags optional
hopeyen dfc9e70
chore(proxy): gen-static-help-output
hopeyen 17c3e67
refactor(EigenDADirectory): help msgs
hopeyen File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
think we should mark these as deprecated and hint people to start moving to the eigenda-directory? Prob want to do it across all of our services (apiserver, nodes, etc). Everything in this PR. And eventually we'll remove all other address flags and only keep the eigenda-directory.
not sure if urfave has a way to mark flags as deprecated. If not then we might need to manually log a warn. cc @dmanc who will be updating our helm charts to use these new flags. Can you also add this as a note to this PR description? This kind of external config changes are very important to highlight.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i made a linear ticket for proxy, and for all services ticket. I will add notes to the PR description