ci: add env and update readme to include the correct mdBook #1595
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bxue-l2
force-pushed
the
ci--publish-md-book-with-github
branch
from
494e095 to
2141d64
Compare
samlaf
reviewed
May 23, 2025
.github/workflows/mdbook.yaml
Outdated
Comment on lines
11
to
13
| environment: | ||
| name: github-pages | ||
| url: ${{ steps.deploy.outputs.page_url }} |
There was a problem hiding this comment.
why are you defining this? it doesn't seem like its used?
There was a problem hiding this comment.
I think it can automatically generate a page link for
https://eigenda.github.io/book/
|
@ian-shim can you add the github book link to here too. 
|
samlaf
previously approved these changes
May 23, 2025
There was a problem hiding this comment.
Not sure this is needed, I think default is to deploy to github pages, which it already is: https://layr-labs.github.io/eigenda/
But doesn't hurt to explicitly add it I guess. Just hope this actually works
|
I add a new section 5f23fd7 |
samlaf
approved these changes
May 23, 2025
bxue-l2
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Publish md book in CI