feat: Validator blacklisting dispersers #1588
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anupsv
changed the title
hopeyen
reviewed
Jun 9, 2025
dmanc
reviewed
Jun 10, 2025
hopeyen
reviewed
Jun 12, 2025
hopeyen
pushed a commit
that referenced
this pull request
Jun 23, 2025
* initial implementation of the blacklist addition * adding the blacklist struct and funcs * checking if the blacklist was hit or not * changing to use disperser id * removing api * add explicit flags * fixing naming * small changes * adding basic unit tests * interfaces and comments * small changes, logs * fixing mock calls * linter fix * adding more test * naming fix * testing validator e2e * adding latest block * unmerged * getting test working * final all parts tested * Update golangci-lint.yml * Update kms_fuzz_test.go * Update config.go * adding cleanup * merge conflict fixes * clean up, comments and old tests * adding deletions after 2 weeks * fixing share state problem in tests * fixing test * cleanup of test --------- Co-authored-by: anupsv <[email protected]> Co-authored-by: anupsv <[email protected]>
hopeyen
pushed a commit
that referenced
this pull request
Jun 23, 2025
* initial implementation of the blacklist addition * adding the blacklist struct and funcs * checking if the blacklist was hit or not * changing to use disperser id * removing api * add explicit flags * fixing naming * small changes * adding basic unit tests * interfaces and comments * small changes, logs * fixing mock calls * linter fix * adding more test * naming fix * testing validator e2e * adding latest block * unmerged * getting test working * final all parts tested * Update golangci-lint.yml * Update kms_fuzz_test.go * Update config.go * adding cleanup * merge conflict fixes * clean up, comments and old tests * adding deletions after 2 weeks * fixing share state problem in tests * fixing test * cleanup of test --------- Co-authored-by: anupsv <[email protected]> Co-authored-by: anupsv <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Adding blacklisting ability of disperser by validators.
This essentially gives the nodes a way to blacklist dispersers based on criteria defined. This PR implements one such criteria which is to blacklist disperser in the case of a bad BlobCert in a batch. While validating blobs in the given batch, if the validation as performed by the function
validateDispersalRequestby the node fails, then the disperser is added to the blacklist on the node.The disperser is blacklisted beginning with 1 hour for 1st offense, 1 day for the 2nd and 1 week for the 3rd. This is done to give the disperser some leeway incase of genuine mistakes and a tradeoff with disperser's who would potentially be malicious. After a blanket 2 weeks of wait time irrespective of the number of offense, the disperser entry is cleaned up to give the disperser another chance to disperse.
Checks