fix: littDB consistent keyfiles #1573
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
litt3
previously approved these changes
May 19, 2025
Signed-off-by: Cody Littley <[email protected]>
litt3
approved these changes
May 20, 2025
junomonster
reviewed
May 26, 2025
| @@ -85,23 +87,23 @@ func newLevelDBKeymap( | |||
| return kmap, requiresReload, nil | |||
| } | |||
|
|
|||
| func (l *LevelDBKeymap) Put(pairs []*types.KAPair) error { | |||
| func (l *LevelDBKeymap) Put(keys []*types.ScopedKey) error { | |||
There was a problem hiding this comment.
I thought we've already discussed about this:
- the Put failed if any key is duplicated.
- Is this the intended behavior?
- I believe it's ok in most circumstances.
There was a problem hiding this comment.
Additionally semantic of Put operations are different between LevelDBKeymap, and the memkeymap that:
- leveldb: entire keys are not stored if any key is duplicated.
- mem: some keys might be stored even if any key is duplicated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Fixes the following issues: