Skip to content

fix: auditor finding 7 #1544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 9, 2025
Merged

fix: auditor finding 7 #1544

merged 2 commits into from
May 9, 2025

Conversation

cody-littley
Copy link
Contributor

Why are these changes needed?

Auditor Request

Finding #7 (Note): Shadowed Loop Variable

  • Although Go’s scoping rules prevent bugs here, reusing i makes me sad in terms of readability. [Code]
  • Recommendation: Rename inner loop variables (e.g., j, idx, or a descriptive name) to improve clarity.

Response

Fixed the issue.

@cody-littley
Fix auditor finding 7.
30a19b0 
Signed-off-by: Cody Littley <[email protected]>
@cody-littley cody-littley requested a review from litt3 May 8, 2025 15:17
@cody-littley cody-littley self-assigned this May 8, 2025
@cody-littley cody-littley changed the title Fix auditor finding 7. fix: auditor finding 7 May 8, 2025
@cody-littley cody-littley merged commit 8b79095 into master May 9, 2025
15 checks passed
@cody-littley cody-littley deleted the litt-audit-f7 branch May 9, 2025 15:24
ethenotethan pushed a commit that referenced this pull request May 14, 2025
@cody-littley @ethenotethan
fix: auditor finding 7 (#1544)
1fc383a 
Fix auditor finding 7.

Signed-off-by: Cody Littley <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litt3 litt3 litt3 approved these changes

Assignees

@cody-littley cody-littley

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cody-littley @litt3