Skip to content

fix: Quorum threshold checking #1530

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 6, 2025
Merged

fix: Quorum threshold checking #1530

merged 1 commit into from
May 6, 2025

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented May 6, 2025 •
edited
Loading

Bug Description

  • The previous code was asserting that the number of quorums defined in the blob header must match the number of quorums in the batch
    • This is not a correct assertion, since the batch may include more quorums than the blob
  • The previous code was also asserting that every quorum in the batch meets the defined threshold, but we should only assert that the quorums in the blob header meet the threshold

Fix

I removed the incorrect assertion, and fixed the reporting for unmet thresholds

@litt3 litt3 self-assigned this May 6, 2025
@litt3 litt3 marked this pull request as ready for review May 6, 2025 18:03
@litt3 litt3 requested review from cody-littley and ian-shim May 6, 2025 18:03
@litt3 litt3 requested a review from anupsv May 6, 2025 18:42
@litt3 litt3 merged commit 13dbab1 into master May 6, 2025
17 checks passed
@litt3 litt3 deleted the fix-threshold-check branch May 6, 2025 18:53
anupsv
anupsv reviewed May 6, 2025
View reviewed changes
Copy link
Contributor

@anupsv anupsv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

ethenotethan pushed a commit that referenced this pull request May 8, 2025
@litt3 @ethenotethan
fix: Quorum threshold checking (#1530)
636f54d 
Fix quorum threshold checking

Signed-off-by: litt3 <[email protected]>
ethenotethan pushed a commit that referenced this pull request May 14, 2025
@litt3 @ethenotethan
fix: Quorum threshold checking (#1530)
dbf7b7d 
Fix quorum threshold checking

Signed-off-by: litt3 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsv anupsv anupsv left review comments

@cody-littley cody-littley cody-littley approved these changes

@ian-shim ian-shim Awaiting requested review from ian-shim

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litt3 @anupsv @cody-littley