feat: LittDB caching #1526
Merged
feat: LittDB caching #1526
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
litt3
reviewed
May 6, 2025
common/cache/fifo_cache.go
Outdated
|
|
||
| // expirationRecord is a record of when a key was inserted into the cache, and is used to decide when it should be | ||
| // evicted. | ||
| type expirationRecord struct { |
There was a problem hiding this comment.
There is some mixed terminology throughout this PR: eviction and expiration seem to be used interchangeably. Probably best to settle on a single term, unless there is a nuanced difference I'm missing?
There was a problem hiding this comment.
They mean the same thing in this context. Decided to go with "eviction".
Signed-off-by: Cody Littley <[email protected]>
litt3
approved these changes
May 8, 2025
ethenotethan
pushed a commit
that referenced
this pull request
May 14, 2025
* Improved littDB caching. Signed-off-by: Cody Littley <[email protected]> * Added separate read and write cache. Signed-off-by: Cody Littley <[email protected]> * Add metrics for the cache. Signed-off-by: Cody Littley <[email protected]> * Configure validator read rate limits Signed-off-by: Cody Littley <[email protected]> * Add caching unit test. Signed-off-by: Cody Littley <[email protected]> * made suggested changes Signed-off-by: Cody Littley <[email protected]> --------- Signed-off-by: Cody Littley <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Add a read and write cache to littDB, and support operations that are cache aware. Add cache aware throttling to the
GetChunks()validator RPC.