Skip to content

refactor: move data api types into its own file #1510

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 28, 2025
Merged

refactor: move data api types into its own file #1510

merged 1 commit into from
Apr 28, 2025

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Apr 28, 2025 •
edited
Loading

Why are these changes needed?

To standardize the data APIs, we have to standardize the data types.

This is the first step towards data API domain types, decoupled from the internal types.

This PR itself should be no-op.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from dmanc and pschork and removed request for dmanc April 28, 2025 22:55
@jianoaix jianoaix merged commit f9ef5c2 into Layr-Labs:master Apr 28, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@pschork pschork Awaiting requested review from pschork

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @dmanc