Skip to content

chore(accountant): more informative error msg #1487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 22, 2025
Merged

chore(accountant): more informative error msg #1487

merged 2 commits into from
Apr 22, 2025

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Apr 22, 2025 •
edited
Loading

Why are these changes needed?

Customers are confused when they get this error.
Include accountId in error message, and suggest depositing ETH in PaymentVault contract.

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@samlaf
chore(accountant): more informative error msg
9031aad 
include accountId in error message, and suggest depositing
ETH in PaymentVault contract.
@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 22, 2025 •
edited
Loading

The latest Buf updates on your PR. Results from workflow Buf Proto / buf (pull_request).

BuildFormatLintBreakingUpdated (UTC)
✅ passed✅ passed✅ passed✅ passedApr 22, 2025, 12:57 PM

@samlaf samlaf requested review from hopeyen and litt3 April 22, 2025 12:12
@samlaf samlaf merged commit 774775d into master Apr 22, 2025
17 checks passed
@samlaf samlaf deleted the chore--better-error-msg-in-accountant branch April 22, 2025 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@litt3 litt3 litt3 approved these changes

@hopeyen hopeyen Awaiting requested review from hopeyen

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samlaf @litt3