Skip to content

fix: Make local copy of loop variable #1465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 11, 2025
Merged

fix: Make local copy of loop variable #1465

merged 2 commits into from
Apr 11, 2025

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Apr 10, 2025

Bug

  • When doing distributed retrieval, these warnings show up
Apr 10 19:21:09.761 WRN v2/retrieval_client.go:138 failed to verify chunks from operator component=RetrievalClient operator=ea77395332488b77d4040e93c31bd5802e735ad4daa4f4514ee677390ce88205 err="invalid number of frames and indices: 754 != 930"
  • The problem was using loop variables in submitted work to the pool
  • Responses from different validators were getting scrambled up

Fix

  • Make a local copy

@litt3 litt3 requested a review from cody-littley April 10, 2025 20:41
@litt3 litt3 self-assigned this Apr 10, 2025
@litt3 litt3 requested a review from ian-shim April 10, 2025 20:55
@litt3 litt3 marked this pull request as ready for review April 10, 2025 20:55
@litt3 litt3 merged commit 36aae2c into master Apr 11, 2025
15 checks passed
@litt3 litt3 deleted the concurrency-bug branch April 11, 2025 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cody-littley cody-littley cody-littley approved these changes

@ian-shim ian-shim ian-shim approved these changes

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litt3 @cody-littley @ian-shim