Skip to content

fix: set the right cache control ttl for v2 APIs #1463

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Apr 9, 2025
Merged

fix: set the right cache control ttl for v2 APIs #1463

merged 2 commits into from
Apr 9, 2025

Conversation

jianoaix
Copy link
Contributor

@jianoaix jianoaix commented Apr 9, 2025 •
edited
Loading

Why are these changes needed?

Audit the cache control of v2 dataapi, and get them right (tradeoff of freshness and cache hit)

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix jianoaix requested review from anupsv and dmanc April 9, 2025 23:12
@jianoaix jianoaix merged commit 10d1fcf into Layr-Labs:master Apr 9, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsv anupsv anupsv approved these changes

@dmanc dmanc Awaiting requested review from dmanc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @anupsv