Skip to content

Conversation

samlaf
Copy link
Collaborator

@samlaf samlaf commented Apr 1, 2025

Closes EGDA-1102.

Broke down v2 integration spec into separate sections for easier readability and access to auto-generated TOC
Merged the rollup stack pages into a single page given that there isn't much on there yet.

image

Why are these changes needed?

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

Broke down v2 integration spec into separate sections for easier readability and access to auto-generated TOC

Merged the rollup stack pages into a single page given that there isn't much on there yet.
@samlaf samlaf requested review from mmurrs, litt3 and bxue-l2 April 1, 2025 18:43
@samlaf samlaf requested a review from litt3 April 6, 2025 14:16
@samlaf
Copy link
Collaborator Author

samlaf commented Apr 6, 2025

@litt3 I went ahead and resolved all the comments that you are left which were straightforward to fix. Left the non/less-trivial ones open, if you care to take a second look. Thanks for the thorough review!

@samlaf samlaf requested a review from litt3 April 7, 2025 17:40
@samlaf samlaf merged commit 260600d into master Apr 8, 2025
14 checks passed
@samlaf samlaf deleted the mdbook--cleanup-integration-section branch April 8, 2025 03:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants