Skip to content

Conversation

yujiezhu0
Copy link
Contributor

@yujiezhu0 yujiezhu0 commented Mar 19, 2025

Why are these changes needed?

[Breaking Changes] Audit fix implementation to add signature replay protection for AuthenticatePaymentStateRequest

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@yujiezhu0 yujiezhu0 changed the title Add signature replay protection for AuthenticatePaymentStateRequest [Breaking Changes] Add signature replay protection for AuthenticatePaymentStateRequest Mar 19, 2025
@yujiezhu0 yujiezhu0 marked this pull request as ready for review March 19, 2025 20:55
@yujiezhu0 yujiezhu0 requested a review from ian-shim March 20, 2025 00:35
@yujiezhu0 yujiezhu0 force-pushed the yujie-sigreplay-0318 branch from 31c295d to ba0a958 Compare March 20, 2025 07:56
@yujiezhu0 yujiezhu0 requested a review from ian-shim March 20, 2025 08:02
@yujiezhu0 yujiezhu0 merged commit 3127d28 into master Mar 20, 2025
12 checks passed
@yujiezhu0 yujiezhu0 deleted the yujie-sigreplay-0318 branch March 20, 2025 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants