-
Notifications
You must be signed in to change notification settings - Fork 238
feat: distributed retrieval operator socket #1403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
97b2a6f
to
5fbcdcd
Compare
c3d0c20
to
083814f
Compare
083814f
to
ce9c8f7
Compare
retriever/server.go
Outdated
@@ -37,15 +35,14 @@ func NewServer( | |||
config: config, | |||
retrievalClient: retrievalClient, | |||
chainClient: chainClient, | |||
indexedState: indexedState, | |||
logger: logger.With("component", "RetrieverServer"), | |||
metrics: metrics, | |||
} | |||
} | |||
|
|||
func (s *Server) Start(ctx context.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we could remove error
from signature since it will always return nil
retriever/v2/server.go
Outdated
) *Server { | ||
metrics := retriever.NewMetrics(config.MetricsConfig.HTTPPort, logger) | ||
|
||
return &Server{ | ||
config: config, | ||
retrievalClient: retrievalClient, | ||
indexedState: indexedState, | ||
chainState: chainState, | ||
logger: logger.With("component", "RetrieverServer"), | ||
metrics: metrics, | ||
} | ||
} | ||
|
||
func (s *Server) Start(ctx context.Context) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
@@ -88,3 +97,36 @@ func getOperatorState(operatorsByQuorum core.OperatorStakes, blockNumber uint32) | |||
|
|||
return state, nil | |||
} | |||
|
|||
func getOperatorStateWithSocket(operatorsByQuorum core.OperatorStakesWithSocket, blockNumber uint32) (*core.OperatorState, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
note to myself: get back to more thorough review here
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should I wait to merge when you feel ready with the more thorough review?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I went over this before I stamped it!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, lets create a ticket to test this on preprod
ticket https://linear.app/eigenlabs/issue/EGDA-1129/[test]-distributed-retrieval |
Why are these changes needed?
call OperatorStateRetriever for operator addresses, allows retrievers to run without thegraph
Checks