Skip to content

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Mar 18, 2025

Why are these changes needed?

call OperatorStateRetriever for operator addresses, allows retrievers to run without thegraph

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen force-pushed the hope/operator-socket branch from 97b2a6f to 5fbcdcd Compare March 18, 2025 21:48
@hopeyen hopeyen self-assigned this Mar 19, 2025
@hopeyen hopeyen force-pushed the hope/operator-socket branch 4 times, most recently from c3d0c20 to 083814f Compare March 19, 2025 19:20
@hopeyen hopeyen force-pushed the hope/operator-socket branch from 083814f to ce9c8f7 Compare March 19, 2025 20:21
@hopeyen hopeyen changed the base branch from master to hope/bump-middleware March 19, 2025 20:21
@hopeyen hopeyen marked this pull request as ready for review March 19, 2025 20:38
@hopeyen hopeyen requested a review from ian-shim March 19, 2025 20:38
Base automatically changed from hope/bump-middleware to master March 20, 2025 06:00
@hopeyen hopeyen requested a review from litt3 March 20, 2025 16:48
@@ -37,15 +35,14 @@ func NewServer(
config: config,
retrievalClient: retrievalClient,
chainClient: chainClient,
indexedState: indexedState,
logger: logger.With("component", "RetrieverServer"),
metrics: metrics,
}
}

func (s *Server) Start(ctx context.Context) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we could remove error from signature since it will always return nil

) *Server {
metrics := retriever.NewMetrics(config.MetricsConfig.HTTPPort, logger)

return &Server{
config: config,
retrievalClient: retrievalClient,
indexedState: indexedState,
chainState: chainState,
logger: logger.With("component", "RetrieverServer"),
metrics: metrics,
}
}

func (s *Server) Start(ctx context.Context) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

@@ -88,3 +97,36 @@ func getOperatorState(operatorsByQuorum core.OperatorStakes, blockNumber uint32)

return state, nil
}

func getOperatorStateWithSocket(operatorsByQuorum core.OperatorStakesWithSocket, blockNumber uint32) (*core.OperatorState, error) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note to myself: get back to more thorough review here

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should I wait to merge when you feel ready with the more thorough review?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I went over this before I stamped it!

Copy link
Contributor

@ian-shim ian-shim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, lets create a ticket to test this on preprod

@hopeyen hopeyen changed the title distributed retrieval: operator socket feat: distributed retrieval operator socket Mar 21, 2025
@hopeyen
Copy link
Contributor Author

hopeyen commented Mar 21, 2025

lgtm, lets create a ticket to test this on preprod

ticket https://linear.app/eigenlabs/issue/EGDA-1129/[test]-distributed-retrieval

@ian-shim ian-shim merged commit 3513a4e into master Mar 21, 2025
13 of 14 checks passed
@ian-shim ian-shim deleted the hope/operator-socket branch March 21, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants