Skip to content

Enhance the metrics summary #1398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 31, 2025
Merged

Enhance the metrics summary #1398

merged 3 commits into from
Mar 31, 2025

Conversation

jianoaix
Copy link
Contributor

Why are these changes needed?

  • Naming improvement: avg_throughput -> average_bytes_per_second
  • Add total_bytes_posted
  • Add the start_timestamp_sec and end_timestamp_sec to indicate what the time range this result is for
  • Fix the return type of API: Metric -> MetricSummary

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@jianoaix
Copy link
Contributor Author

ping?

@jianoaix jianoaix requested a review from dmanc March 19, 2025 23:55
@jianoaix
Copy link
Contributor Author

ping?

@jianoaix
Copy link
Contributor Author

ping x3?

@jianoaix
Copy link
Contributor Author

ping x4?

@jianoaix jianoaix merged commit b6eb103 into Layr-Labs:master Mar 31, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dmanc dmanc dmanc approved these changes

@pschork pschork Awaiting requested review from pschork

@merli-eigenlabs merli-eigenlabs Awaiting requested review from merli-eigenlabs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jianoaix @dmanc