Skip to content

Check multiplication overflow in ValidateEncodingParams #1341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 10, 2025
Merged

Check multiplication overflow in ValidateEncodingParams #1341

merged 2 commits into from
Mar 10, 2025

Conversation

ian-shim
Copy link
Contributor

@ian-shim ian-shim commented Feb 28, 2025 •
edited
Loading

Why are these changes needed?

Ensure that params.ChunkLength*params.NumChunks doesn't result in overflow

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@ian-shim ian-shim requested review from anupsv and jianoaix February 28, 2025 00:42
@ian-shim ian-shim marked this pull request as ready for review February 28, 2025 00:43
anupsv
anupsv reviewed Feb 28, 2025
View reviewed changes
jianoaix
jianoaix approved these changes Mar 4, 2025
View reviewed changes
@ian-shim ian-shim merged commit 6a1bbd9 into Layr-Labs:master Mar 10, 2025
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsv anupsv anupsv approved these changes

+1 more reviewer

@jianoaix jianoaix jianoaix approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ian-shim @anupsv @jianoaix