avoid unnecessary casting #1327
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hopeyen
force-pushed
the
hope/misc-casting
branch
5 times, most recently
from
dbcfd74 to
ea4dd18
Compare
hopeyen
force-pushed
the
hope/misc-casting
branch
from
ea4dd18 to
ed06e20
Compare
anupsv
approved these changes
Feb 26, 2025
| currentReservationPeriod := meterer.GetReservationPeriodByNanosecond(timestamp, a.reservationWindow) | ||
| symbolUsage := uint64(a.SymbolsCharged(numSymbols)) | ||
| symbolUsage := a.SymbolsCharged(numSymbols) |
There was a problem hiding this comment.
Is the a max value for numSymbols that we should be checking ?
There was a problem hiding this comment.
Not enforced by payments, I think it will be checked in validation before it gets to meterer. If you think it is within the meterer scope and should double check, I can add config to the meterer for a maximum number of blobs and add a check
There was a problem hiding this comment.
If it's enforced somewhere else and it's the only call path then no need.
anupsv
approved these changes
Feb 27, 2025
ian-shim
approved these changes
Feb 27, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
https://linear.app/eigenlabs/issue/EGDA-996/eda2-10-[medium]-avoid-lossy-and-unnecessary-casting
Checks