Skip to content

chore: address general comments #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 4, 2025
Merged

chore: address general comments #1324

merged 6 commits into from
Mar 4, 2025

Conversation

hopeyen
Copy link
Contributor

@hopeyen hopeyen commented Feb 25, 2025

Why are these changes needed?

https://linear.app/eigenlabs/issue/EGDA-1001/eda2-15-[info]-miscellaneous-general-comments

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@hopeyen hopeyen requested a review from anupsv February 25, 2025 18:39
@hopeyen hopeyen marked this pull request as ready for review February 25, 2025 18:39
@hopeyen hopeyen merged commit e9d818b into master Mar 4, 2025
12 checks passed
@hopeyen hopeyen deleted the hope/general-comments branch March 4, 2025 18:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@anupsv anupsv anupsv approved these changes

@ian-shim ian-shim ian-shim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hopeyen @anupsv @ian-shim