Blob feed iteration with dynamo pagination #1252
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmanc
reviewed
Feb 10, 2025
| // queryBucketBlobMetadata returns blobs (as metadata) within range [startKey, endKey] from a single bucket. | ||
| // Results are ordered by <RequestedAt, Bobkey> in ascending order. | ||
| // | ||
| // The function handles DynamoDB's 1MB response size limitation by performing multiple queries if necessary. |
There was a problem hiding this comment.
Isn't GetBlobMetadataByRequestedAt already doing pagination?
There was a problem hiding this comment.
It has no information about 1MB underneath in dynamo
dmanc
approved these changes
Feb 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
The blob feed needs to use pagination to get all blob, because Dynamo has a 1MB limit on the response size, so if there are more blobs to fetch, it won't be able to get them all.
Checks