V2 Retrieval Isolation #1181
Merged
V2 Retrieval Isolation #1181
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
supriya-premkumar
force-pushed
the
supriya-egda-819-v1v2-port-separation
branch
3 times, most recently
from
6da5a24 to
f33b818
Compare
supriya-premkumar
force-pushed
the
supriya-egda-819-v1v2-port-separation
branch
2 times, most recently
from
a34665a to
c446a82
Compare
ian-shim
reviewed
Jan 30, 2025
supriya-premkumar
force-pushed
the
supriya-egda-819-v1v2-port-separation
branch
from
c446a82 to
47d0d86
Compare
supriya-premkumar
force-pushed
the
supriya-egda-819-v1v2-port-separation
branch
2 times, most recently
from
6e7971e to
4fbba32
Compare
- Updates operator socket format to host:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPort
- Refactors parseOperatorSocket to handle v2 retrieval socket with strict port validation
- Adds ValidatePort() to core utils
- Adds stricter validation for operator sockets. Valid formats:
- host:v1DispersalPort;v1RetrievalPort
- host:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPort
- Adds host validation supporting both FQDN and IP addr
- Registers node for the new V2 retrieval service
- Removes serverv2 under v1retrieval service
- Adds a check to enable v2Enable when the v2 disperser port or v2 retrieval port is enabled
- Adds a check to ensure specified v1/v2 dispersal/retrieval ports are different
supriya-premkumar
force-pushed
the
supriya-egda-819-v1v2-port-separation
branch
from
4fbba32 to
28ce67e
Compare
pschork
added a commit
that referenced
this pull request
Feb 2, 2025
Update dataAPI swagger BlobFeed response to resolve correct v2.BlobHeader Add Makefile docker-node-group for testing local node Add Makefile run target for running local node (requires local .env) Add Makefile run-update-socket target (requires local .env) Add Makefile run-update-socket-v1 target (requires local .env) Add Makefile run-list-quorums target (requires local .env) Fix swagger gen for v2 BlobHeader Rebase #1181 Add `--disableV1` flag to disable v1 when running in isolation mode Change requirement that V2 ports are specified when V2 is disabled. It was previously impossible to disableV2 without defining v2 ports. ``` 2025/01/31 11:26:53 application failed: enable v2 flag needs to be set when v2 dispersal port (NODE_V2_DISPERSAL_PORT) is specified ``` but if V2 ports were unset then node would still fail to start regardless if `--enableV2` was set or not ``` 2025/01/31 12:13:41 application failed: Required flags "node.v2-dispersal-port, node.v2-retrieval-port" not set ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
host:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPorthost:v1DispersalPort;v1RetrievalPorthost:v1DispersalPort;v1RetrievalPort;v2DispersalPort;V2RetrievalPortChecks