Skip to content

fix: Add salt to blob header conversion util #1177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 28, 2025
Merged

fix: Add salt to blob header conversion util #1177

merged 1 commit into from
Jan 28, 2025

Conversation

litt3
Copy link
Contributor

@litt3 litt3 commented Jan 28, 2025

Why are these changes needed?

  • The blob header was changed, but salt wasn't added to the conversion util

Checks

  • I've made sure the tests are passing. Note that there might be a few flaky tests, in that case, please comment that they are not relevant.
  • I've checked the new test coverage and the coverage percentage didn't drop.
  • Testing Strategy
    • Unit tests
    • Integration tests
    • This PR is not tested :(

@litt3 litt3 self-assigned this Jan 28, 2025
@litt3 litt3 marked this pull request as ready for review January 28, 2025 19:39
@litt3 litt3 requested a review from samlaf January 28, 2025 20:55
@litt3 litt3 merged commit b24dcfa into Layr-Labs:master Jan 28, 2025
9 checks passed
@litt3 litt3 deleted the blob-header-conversion-salt branch January 28, 2025 21:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@samlaf samlaf samlaf approved these changes

@cody-littley cody-littley cody-littley approved these changes

@ethenotethan ethenotethan Awaiting requested review from ethenotethan

@bxue-l2 bxue-l2 Awaiting requested review from bxue-l2

Assignees

@litt3 litt3

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@litt3 @samlaf @cody-littley