Allow relay protos to be larger. #1174
Conversation
Signed-off-by: Cody Littley <[email protected]>
Signed-off-by: Cody Littley <[email protected]>
| @@ -314,7 +315,7 @@ func (c *disperserClient) initOnceGrpcConnection() error { | |||
| var initErr error | |||
| c.initOnceGrpc.Do(func() { | |||
| addr := fmt.Sprintf("%v:%v", c.config.Hostname, c.config.Port) | |||
| dialOptions := getGrpcDialOptions(c.config.UseSecureGrpcFlag) | |||
| dialOptions := getGrpcDialOptions(c.config.UseSecureGrpcFlag, 4*units.MiB) | |||
There was a problem hiding this comment.
isn't this already the default?
There was a problem hiding this comment.
Yes, 4mb is the default. I added an argument to getGrpcDialOptions(), and so in this non-relay code I just preserved the prior behavior.
Signed-off-by: Cody Littley <[email protected]>
| @@ -278,6 +279,13 @@ var ( | |||
| EnvVar: common.PrefixEnvVar(EnvVarPrefix, "DISPERSAL_AUTHENTICATION_TIMEOUT"), | |||
| Value: time.Minute, | |||
| } | |||
| RelayMaxGRPCMessageSizeFlag = cli.IntFlag{ | |||
There was a problem hiding this comment.
needs to be added to optionalFlags below
relay/cmd/flags/flags.go
Outdated
| @@ -66,7 +67,7 @@ var ( | |||
| Usage: "The size of the blob cache, in bytes.", | |||
| Required: false, | |||
| EnvVar: common.PrefixEnvVar(envVarPrefix, "BLOB_CACHE_SIZE"), | |||
| Value: 1024 * 1024 * 1024, | |||
| Value: units.GiB, | |||
There was a problem hiding this comment.
not sure what we're provisioning in prod, but these should be a lot bigger, no?
probably fine to leave it 1 GiB here. We can provision different values depending on the machine type in prod
There was a problem hiding this comment.
I set this to 1gb when working on OOM problems. Now that the cache can correctly gauge its size, I'm ok changing it back higher again. It is now 8 * units.GiB in this PR.
Signed-off-by: Cody Littley <[email protected]>
Why are these changes needed?
Allow relay protobufs to be larger.